-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Workflow to Build and Push Docker Images in Docker Hub #550
base: main
Are you sure you want to change the base?
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
@wkyoshida mention about this workflow long ago, but I completely forgot to add it. 😅 |
on: | ||
push: | ||
branches: | ||
- master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- master | |
- main |
Aren't our default branch is main?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beyond this, I think that it makes sense that the trigger for this is a release and not a push to main
as we would only want full releases to go to Docker Hub.
Also can we add a checker if the repo is CC: @andrewtavis |
Ya that'd be really great so forks don't try to push :) |
Beyond my comment above, let's make sure to add an explicit comment to the code that checks for the repo, as if someone does want to fork and host their fork on Docker Hub, then there's really no problem with that. It would be good if we made it clear where the change would need to go to disable the repo check 😊 |
Contributor checklist
pytest
command as directed in the testing section of the contributing guideDescription
This GitHub Actions workflow builds and pushes a Docker image to Docker Hub whenever there is a push to the master branch or a manual trigger using
workflow_dispatch
. It simplifies Docker image deployment and supports multi-platform builds.Requirements:
DOCKERHUB_USERNAME
: Docker Hub username.DOCKERHUB_TOKEN
: Docker Hub personal access token.Related issue