-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Implemented back button in the action bar #77
feat:Implemented back button in the action bar #77
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
This is looking so good, @angrezichatterbox! It's really looking like Scribe-iOS finally 🤩 One thing to note: Would it be possible for the action bar to have a bit of a margin at the top? Maybe bring everything down like a centimeter or whatever looks ok on your end? The headers seem a bit high, and the back buttons like of blend in with the icons at the top of the screen. After this we'll be good to merge! 😊 |
How does this look? Should I make them come slightly below in the case of the subpages? |
Is looking great, @angrezichatterbox! The only thing I'd change is that sub headers like |
I have made the required changes in the latest commit. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looking really great, @angrezichatterbox! Really is coming along so well :) Just need the logo and the directions for the installation to be a bit more explicit, and then it'll really be looking like Scribe 😊
Contributor checklist
Description
Related issue