Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(command-bar): move cursor to end of input after typing #303

Merged

Conversation

smalik2811
Copy link
Contributor

Contributor checklist


Description

This commit addresses issue #286 by improving the cursor behavior within the command bar.

Previously, the cursor remained fixed after the command prompt, even as the user typed input. This has been corrected so that the cursor now dynamically moves to the end of the input text as the user types, providing a more intuitive and user-friendly experience.

Related issue

This commit addresses issue scribe-org#286 by improving the cursor behavior within the command bar.

Previously, the cursor remained fixed after the command prompt, even as the user typed input. This has been corrected so that the cursor now dynamically moves to the end of the input text as the user types, providing a more intuitive and user-friendly experience.

Closes scribe-org#286
Copy link

github-actions bot commented Jan 23, 2025

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

Nice, @smalik2811! We'll get to the review here in the coming days :)

@andrewtavis andrewtavis self-requested a review January 24, 2025 20:06
Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really some amazing work, @smalik2811! Great to have you on the project :) Would be happy to have you at our dev sync tomorrow if you had interest! Details for that are in the General channel on Matrix :)

@andrewtavis andrewtavis merged commit db94d03 into scribe-org:main Jan 24, 2025
4 checks passed
@smalik2811 smalik2811 deleted the fix-cursor-movement-command-bar branch January 25, 2025 02:14
@smalik2811
Copy link
Contributor Author

Thank you so much 😊, @andrewtavis, for the kind words and encouragement! I'm really enjoying 😍 contributing to the project as well. I'd love to join the dev sync tomorrow – excited to learn about the upcoming features!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants