Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add loading message when loading template in create pipeline form #583

Merged
merged 3 commits into from
Aug 14, 2020
Merged

fix: add loading message when loading template in create pipeline form #583

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2fcf2b
fix: add loading message when loading template in create pipeline form
Aug 13, 2020
0aac4fe
fix: add another case to handle both loading and search no matches
Aug 13, 2020
e3533f6
Merge branch 'master' into adong/show-loading
adong Aug 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/components/pipeline-create-form/template.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
onchange=(action "selectTemplate")
searchField="name"
searchEnabled=true
noMatchesMessage="Loading..."
Copy link
Member

@jithine jithine Aug 13, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this mean, if I search for something and it's not there in the list, it still shows Loading ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct. It will show Loading... for non-matched items. Let me update to handle that case.

as |template| }}
{{template.name}}
{{/power-select}}
Expand Down Expand Up @@ -91,4 +92,4 @@
delayHide="1000"}}
What is a <a href="https://docs.screwdriver.cd/user-guide/configuration/" target="_blank" rel="noopener">screwdriver.yaml</a>
{{/bs-tooltip}}
</div>
</div>