Node 16 #73
Merged
Node 16 #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move to Node.js v16 and fix up
package-lock.json(andpackage.jsonto a lesser extent).Note that
--use-legacy-peer-depsis no longer necessary due to these changes -- hooray!I re-added the step to install native dependencies to fix the build after the Node.js upgrade. Depending on the combination of Node.js version and npm dependency versions, sometimes these native dependencies are necessary and sometimes they're not. Installing them never hurts, other than a bit of extra time, so I think it's safer to leave them in. They're necessary when
node-gypfails to download a precompiled version of a library, probablycanvas, which leads to a message like this:npm ERR! node-pre-gyp WARN Pre-built binaries not found for [email protected] and [email protected] (node-v93 ABI, glibc) (falling back to source compile with node-gyp)