Add support for JSON flag parsing #167
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces support for parsing the flags supported by FSO.
This will use the JSON output of FSO for enumerating the available joysticks if possible. This should fix the joystick issue which was caused by a mismatch between the SDL version FSO and wxLauncher uses.
This does not respect the screen index which may have been specified in the FSO config but since the old code didn't respect that either it shouldn't be an issue.
asarium
force-pushed
the
feature/jsonFlags
branch
4 times, most recently
from
fe9c819
to
1fe4178
Compare
asarium
force-pushed
the
feature/jsonFlags
branch
from
1fe4178
to
663f806
Compare
The old version used an outdated version of the template which caused issues with newer NSIS versions.
|
I have built a test build with these changes: http://www.mediafire.com/file/lmfqqd7cwekqekj/wxlauncher-0.12.0-rc.3.exe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces support for the new JSON flag output mode of FSO. This convert the flag parsing, joystick enumeration, resolution enumeration, config path retrieval and OpenAL device enumeration to this new output format (obviously with a fallback if the build does not support it).
This should also fix the joystick configuration issue which happens since the SDL version of FSO has been updated. Since wxLauncher will now always use the GUIDs as they are seen by FSO there will be no more configuration mismatches.