Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of datetime.utcnow() #800

Closed
wants to merge 2 commits into from

Conversation

adamchainz
Copy link
Contributor

@adamchainz adamchainz commented Oct 4, 2024

Fixes #799.

This needs further testing to check whether the issue from #400 is fixed in the core agent or if it needs handling here, by changing the formatting to remove timezone info.

I no longer have a working dev setup for this though, so I will leave that testing in your hands. (I used to be the maintainer of this package.)

@adamchainz adamchainz force-pushed the rewrite_utcnow_usage branch from 3eca640 to 61d2861 Compare October 4, 2024 11:06
@lancetarn
Copy link
Contributor

Thank you for this, Adam. And for all your work here and with Django. We'll run it through the test apps... which you have also contributed. This is one of those changes that my soul knows is good for python but is not exactly going to be painless. We will schedule a look at the core agent to check out options.

@lancetarn
Copy link
Contributor

Work is in-flight to handle multiple timestamp formats in the Core Agent.

@lancetarn
Copy link
Contributor

I think the Core Agent can actually handle offset information in an expected format as-is. I've collected these changes and made some tiny tweaks in #801 and will bring them home there. Thank you so much again for the major effort here!

@lancetarn lancetarn closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove use of datetime.utcnow()
2 participants