Unpin psutil dependency #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Tim! This is a good reminder that some more cleanup is due. These test failures seem unrelated, we'll have to see what else has shifted here. |
|
Came here to say same :) |
lancetarn
force-pushed
the
unpin-psutil
branch
from
d55b607
to
d4f117d
Compare
It is unlikely, but if the internal process cache is not cleared, we could have a stale result.
|
Sounds like this check was due to this change in psutil? giampaolo/psutil#2396 Makes sense. Glad to see this moving forward! |
lancetarn
approved these changes
Oct 4, 2024
|
Yeah. I doubt it was going to be a problem but it seems harmless to look out for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.