Capture full URL in urllib3 spans #587
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think there's still a bug here where we sometimes capture the wrong hostname, due to a connection pool getting reused for different hosts. It seems |
Spotted whilst debugging a customer's traces.
While requests isn't instrumented directly, we do instrument it via urllib3. These tests do a basic verification of that.
tim-schilling
force-pushed
the
capture_full_url
branch
from
3ca8a74
to
7d40266
Compare
|
I've dug into this and tried recreating it via requests and urllib3. I exceeded the pool size limits and increased the count to see if it was an odd bug exposed by repetition. I was unable to reproduce the bug. Looking at the code, I'm not sure how it would exist since we generate the absolute url from the wrapped connection instance. If CI passes, I'm inclined to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted whilst debugging a customer's traces.