Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instrument aioredis #562

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Instrument aioredis #562

wants to merge 6 commits into from

Conversation

adamchainz
Copy link
Contributor

Rebuild of #552 with tracking in an aioredis-specific instrument submodule.

@adamchainz
Copy link
Contributor Author

This continues to suffer from the problem in #469 - instrumentation won't be preserved for async tasks triggered underneath the main one. We should solve it before merging this.

@adamchainz adamchainz mentioned this pull request Sep 1, 2020
Closed
@adamchainz adamchainz changed the base branch from master to issue_557_span_context_manager September 3, 2020 16:15
Base automatically changed from issue_557_span_context_manager to master September 3, 2020 16:27
@tim-schilling
Copy link
Collaborator

There are changes occurring for pipelines in aioredis v2 which is in alpha currently. It appears that the API will be different so we may want to hold off on this until v2 is finalized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamchainz @tim-schilling @yoav-orca