Fallback to use image_src if ogp::image isn't set #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Some websites (eg. imgur.com) don't have OGP tags but they do indicated an image associated with the page using image_src. Facebook's oEmbed falls back on this if OGP data isn't avalable.
|
Looks like a good idea to me. It's be great if we can also build in a graceful degradation to the first image on the page if nothing else is available. |
scottmac
added a commit
that referenced
this pull request
Mar 18, 2013
Fallback to use image_src if ogp::image isn't set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
indicated an image associated with the page using image_src meta tag.