Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with nytimes.com (and other sites) #29

Open
booruguru opened this issue Nov 9, 2014 · 3 comments
Open

Doesn't work with nytimes.com (and other sites) #29

booruguru opened this issue Nov 9, 2014 · 3 comments

Comments

@booruguru
Copy link

I am unable to retrieve og:image from some web sites, most notably nytimes.com...even though they clearly have the value defined in their HTML head.

AramZS referenced this issue Jan 8, 2015
Fallback to use image_src if ogp::image isn't set
AramZS added a commit to AramZS/opengraph that referenced this issue Jan 8, 2015
The property `_values` was misnamed as `values` causing the function to always consider image retrieval a failure, often not offering an alternative. Discovered this problem while working on PressForward. This simple fix should resolve a ton of problems, most notably scottmac#29.
@vwasteels
Copy link

this script will not work with single page applications, since the content will be loaded with javascript and the initial content is a basic html page that include all needed scripts.

@AramZS
Copy link
Contributor

AramZS commented Jan 19, 2018

@vwasteels That is a separate issue for sure. And a deep dive into headless browsing.

@andreas83
Copy link

its 2020 and getting data via a headless browser is not a big deal..
http://jonnnnyw.github.io/php-phantomjs/4.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants