-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't work with nytimes.com (and other sites) #29
Comments
AramZS
added a commit
to AramZS/opengraph
that referenced
this issue
Jan 8, 2015
The property `_values` was misnamed as `values` causing the function to always consider image retrieval a failure, often not offering an alternative. Discovered this problem while working on PressForward. This simple fix should resolve a ton of problems, most notably scottmac#29.
this script will not work with single page applications, since the content will be loaded with javascript and the initial content is a basic html page that include all needed scripts. |
@vwasteels That is a separate issue for sure. And a deep dive into headless browsing. |
its 2020 and getting data via a headless browser is not a big deal.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I am unable to retrieve og:image from some web sites, most notably nytimes.com...even though they clearly have the value defined in their HTML head.
The text was updated successfully, but these errors were encountered: