Skip to content

Commit

Permalink
Images always failing - results in no images
Browse files Browse the repository at this point in the history
The property `_values` was misnamed as `values` causing the function to always consider image retrieval a failure, often not offering an alternative. Discovered this problem while working on PressForward. This simple fix should resolve a ton of problems, most notably scottmac#29.
  • Loading branch information
AramZS committed Jan 8, 2015
1 parent 3d2180e commit 5f37fbf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion OpenGraph.php
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ static private function _parse($HTML) {
}

//Fallback to use image_src if ogp::image isn't set.
if (!isset($page->values['image'])) {
if (!isset($page->_values['image'])) {
$domxpath = new DOMXPath($doc);
$elements = $domxpath->query("//link[@rel='image_src']");

Expand Down

0 comments on commit 5f37fbf

Please sign in to comment.