Login and signup with facebook and email working #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
shehand
requested changes
Mar 23, 2023
| @@ -10,7 +10,7 @@ import { | |||
| ScrollView, | |||
| } from "react-native"; | |||
| import { AccessToken, LoginManager } from "react-native-fbsdk"; | |||
| import { f, auth } from "../../../config/config.js"; | |||
| import { f, auth } from "../../../config/config.example.js"; | |||
There was a problem hiding this comment.
This is wrong. We should use config.js and not config.example.js.
The idea of having config.example.js is to give a template to the developer to setup the config file and the file should be renamed to config.js when doing the development. So please revert this change.
|
Before making changes
After using correct imports WhatsApp.Video.2023-03-24.at.2.43.15.PM.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
I am running the latest version
The login and sign up with email/password and facebook is not working but after using correct imports from firebase and using correct function from react-native-fbsdk it is working fine now