Java exception and assets load fix #146
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiKul10
reviewed
Mar 24, 2022
config/config.example.js
Outdated
| @@ -1,19 +1,38 @@ | |||
| import firebase from "firebase"; | |||
| import { ALREADY_LAUNCHED } from "@env"; | |||
AbhiKul10
reviewed
Mar 24, 2022
config/config.example.js
Outdated
Comment on lines
31
to
38
| "https://api.rss2json.com/v1/api.json?rss_url=https://medium.com/feed/scorelab"; | ||
| export const GITHUB_API = | ||
| "https://api.github.com/orgs/scorelab/repos?sort=pushed&per_page=10"; | ||
|
|
||
| export default { | ||
| ALREADY_LAUNCHED, | ||
| }; |
There was a problem hiding this comment.
No need. Update Accordingly
There was a problem hiding this comment.
Ok I will revert it
|
Shall we decouple this PR in a way so that all isssue has a one PR related to it. |
|
Yeah sure I too was looking a way to do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR include 5 fixes:
fix for java.lang.ExceptionInInitializerError
Resources for this fix:
fix for unable to load script from assets Unable to load script from assets 'index.android.bundle'. #138
Resources for this fix:
fix for dependency
Updated package.js as @react-native-community/toolbar-android module is missing in the dependency
fix for missing import of Platform in forumbox/style.js
modified **style.js **
modified config.example.js