Adding missing logo in the readme.md file #895
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaDogg
requested changes
Mar 7, 2020
|
Looks like you have got few commits from the master branch added to your pull request can you remove them 😁 |
slahirucd7
force-pushed
the
documentation_branch
branch
from
7634f70
to
625c03c
Compare
|
It would be easier to create a new pull request by branching from develop, updating README, then sending the pull request. |
|
I can still see all the changes. No need to add what's in Master branch :) |
slahirucd7
force-pushed
the
documentation_branch
branch
from
625c03c
to
123424f
Compare
|
@JaDogg Can you please check again now ? |
JaDogg
previously approved these changes
Mar 7, 2020
|
Looks good to me. 😁😁😁 |
|
@kmehant Please review. |
kmehant
previously approved these changes
Mar 9, 2020
|
@JaDogg Please add a review here as your old review has been ignored due to a merge commit 😄 |
|
@JaDogg Please review :) |
JaDogg
approved these changes
May 20, 2020
|
I'm seeing a merge conflict. fix it please. |
|
Closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the readme.md file the logo associated to the product was missing. Therefore I changed it to display the logo.
Related Issue
N/A
Motivation and Context
Since this page gives the first impression to the user, better if repository have the missing logo.
How Has This Been Tested?
This was tested using locally as well as in the GitHub web readme.md web page of the repository.
Screenshots (In case of UI changes):
Types of changes
This how it was displayed before adding the image with new path
This how now the product logo is going to be displayed in the repository
Checklist: