Modified paths to work on xdg-config-dirs, complying with xdg standard #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 6, 2023 12:03
…y with xdg standards" This reverts commit 6b4617f.
…to comply with xdg standards"" This reverts the reverted commit because I am literally figuring out how to use git right now.
Anyway, this removes a line because nano kept spitting an error saying "Normal has no prefix" or something
davidhcefx
suggested changes
Feb 3, 2024
| @@ -23,7 +23,6 @@ icolor brightblue " brightblue" | |||
| icolor brightmagenta " brightmagenta" | |||
| icolor brightcyan " brightcyan" | |||
| icolor brightwhite " brightwhite" | |||
| icolor brightnormal " brightnormal" | |||
There was a problem hiding this comment.
This is already submitted in: #391
I think we should separate different PR for different issues.
davidhcefx
reviewed
Feb 3, 2024
| } | ||
|
|
||
| _update_nanorc_lite(){ | ||
| sed -i '/include "\/usr\/share\/nano\/\*\.nanorc"/i include "~\/.nano\/*.nanorc"' "${NANORC_FILE}" | ||
| sed -i '/include "\/usr\/share\/nano\/\*\.nanorc"/i include "~\/.conig.\/nano\/*.nanorc"' "${NANORC_FILE}" |
There was a problem hiding this comment.
typo, plus there is extra dot after config
davidhcefx
reviewed
Feb 3, 2024
| } | ||
|
|
||
| NANORC_FILE=~/.nanorc | ||
| NANORC_FILE=~/.config\/nano\/nanorc |
There was a problem hiding this comment.
I don't think it is correct to change this to ~/.config/nano/nanorc. Here, it is referencing the nano rcfile under home, which is the default rcfile path. The same issue with line 21.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the pull request title says, just changes the paths.
Also fixes one error on nano blaming line 26 of nanorc.nanorc
Hope it helps. Literally my first PR