Add type to loop variables only #947
Merged
+341
−248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominikKamp
reviewed
Jan 25, 2025
DominikKamp
reviewed
Jan 25, 2025
DominikKamp
reviewed
Jan 25, 2025
DominikKamp
reviewed
Jan 25, 2025
Co-authored-by: DominikKamp <[email protected]>
DominikKamp
reviewed
Jan 27, 2025
DominikKamp
reviewed
Jan 27, 2025
DominikKamp
reviewed
Jan 27, 2025
DominikKamp
reviewed
Jan 27, 2025
DominikKamp
reviewed
Jan 27, 2025
DominikKamp
reviewed
Jan 27, 2025
DominikKamp
reviewed
Jan 27, 2025
DominikKamp
reviewed
Jan 27, 2025
DominikKamp
reviewed
Jan 27, 2025
DominikKamp
reviewed
Jan 27, 2025
DominikKamp
reviewed
Jan 27, 2025
|
@Joao-Dionisio From my side this would be fine but some pyscipopt tests seem to fail although there is a green button so please have a look. |
|
@DominikKamp yeah, everything seems to be fine, you just need to approve the PR (I can't do it because I'm the one who created it). |
DominikKamp
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #946, but without adding types to the arguments, as it was controversial.
We should probably also add a performance test at some point. Naturally, SCIP should be where the majority of time is spent, but maybe someone is doing a lot of stuff on the Python side.
The performance gain of this is probably marginal, but faster is better than slower, I suppose.