OSCEM metadata #38
OSCEM metadata #38
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
|
|
||
| @classmethod | ||
| def runCTFestimation(cls): | ||
| prot = cls.newProtocol(CistemProtCTFFind, |
There was a problem hiding this comment.
Trying to reduce the external dependencies, could you replace the cistemCTFFind for the one in XMIPP?
|
|
||
| @classmethod | ||
| def runPicking(cls): | ||
| prot = cls.newProtocol(SphireProtCRYOLOPicking, |
There was a problem hiding this comment.
Trying to reduce the external dependencies, could you replace the cryolopicking for the one in XMIPP?
There was a problem hiding this comment.
Review the new "issues" sonarCloud reports
At least the High severity ones
| """ This is the class for generating the OSCEM metadata json file from Scipion workflow | ||
| """ | ||
| _label = 'OSCEM Metadata' | ||
|
|
There was a problem hiding this comment.
Add the label for the protocol:
from pyworkflow import UPDATED, NEW
_devStatus = NEW
| pointerClass='ProtAlignMovies', | ||
| help="Movie alignment used", | ||
| condition=CONDITION_MOVIES, | ||
| allowsNull=True) |
There was a problem hiding this comment.
Is movieAlignment optional? just to confirm
|
No description provided.