Skip to content

Commit

Permalink
Merge pull request #195 from scipion-em/devel
Browse files Browse the repository at this point in the history
Fix config --overwrite: scipion.template (deleted) not needed.
  • Loading branch information
JorMaister authored Aug 9, 2024
2 parents ccd9026 + 0f07877 commit 517660f
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
2 changes: 2 additions & 0 deletions CHANGES.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
V3.6.1
- Fix config --overwrite: scipion.template (deleted) not needed.
V3.6.0
- Template window shows browser icons
- Template window adapted to use workflow hub templates
Expand Down
2 changes: 1 addition & 1 deletion scipion/__init__.py
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
__version__ = '3.6.0'
__version__ = '3.6.1'

4 changes: 1 addition & 3 deletions scipion/install/plugin_funcs.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from pwem import Domain
from pyworkflow.utils import redStr, yellowStr
from pyworkflow.utils.path import cleanPath
from pyworkflow import LAST_VERSION, CORE_VERSION, OLD_VERSIONS, Config
from pyworkflow import LAST_VERSION, CORE_VERSION, Config
from importlib import reload

NULL_VERSION = "0.0.0"
Expand All @@ -30,8 +30,6 @@
PIP_UNINSTALL_CMD = '{0} -m pip uninstall -y %s'.format(
Environment.getPython())

versions = list(OLD_VERSIONS) + [LAST_VERSION]


class PluginInfo(object):

Expand Down
6 changes: 3 additions & 3 deletions scipion/scripts/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -196,9 +196,6 @@ def createConf(fpath, ftemplate, unattended=False):
print(yellow("* Creating configuration file: %s" % fpath))
print("Please edit it to reflect the configuration of your system.\n")

if not os.path.exists(ftemplate):
raise FileNotFoundError('Missing file: %s' % ftemplate)

# Special case for scipion config
if getTemplateName(SCIPION_CONF) in ftemplate:

Expand All @@ -214,6 +211,9 @@ def createConf(fpath, ftemplate, unattended=False):
# Create the actual configuration file.
cf.write(open(fpath, 'w'))
else:
if not os.path.exists(ftemplate):
raise FileNotFoundError('Missing file: %s' % ftemplate)

# For host.conf and protocols.conf, just copy files
copyfile(ftemplate, fpath)

Expand Down

0 comments on commit 517660f

Please sign in to comment.