Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use uv for all pip installs #50

Merged
merged 2 commits into from
Nov 12, 2024
Merged

ci: Use uv for all pip installs #50

merged 2 commits into from
Nov 12, 2024

Conversation

matthewfeickert
Copy link
Member

  • Use 'uv pip' for all calls to 'pip install' in CI workflows.
  • Use 'pytest' over 'python -m pytest' as calling pytest as a main module also includes the current directory on the path.

@matthewfeickert matthewfeickert requested a review from jpivarski May 7, 2024 00:17
@matthewfeickert matthewfeickert self-assigned this May 7, 2024
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
* Use 'uv pip' for all calls to 'pip install' in CI workflows.
   - c.f. https://github.com/astral-sh/uv/
* Use 'pytest' over 'python -m pytest' as calling pytest as a main
  module also includes the current directory on the path.
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that I missed this, all the way back in May. Being forward-looking and using uv instead of pip makes sense for this repo, so I'm updating the PR to main and will merge it when the tests pass.

@jpivarski jpivarski enabled auto-merge (squash) November 12, 2024 14:45
@jpivarski jpivarski merged commit 17dbf70 into main Nov 12, 2024
12 checks passed
@jpivarski jpivarski deleted the ci/use-uv branch November 12, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants