-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Use intersphinx_registry to keep intersphinx urls up to date #2559
base: main
Are you sure you want to change the base?
Conversation
I think that will be of interest for @matthewfeickert from our discussion in Quansight-Labs/intersphinx_registry#42 |
I think one of the difference is it will point toward uproot stable instead of latest (which is the dev version).
9cef667
to
2b77cb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks, @Carreau! I'll need to review this more in the morning (my time) but I think we'll also need to add intersphinx-registry
as a dependency to the docs
extra
Lines 116 to 130 in 1f1adc7
docs = [ | |
"pyhf[xmlio,contrib]", | |
"sphinx>=7.0.0", # c.f. https://github.com/scikit-hep/pyhf/pull/2271 | |
"sphinxcontrib-bibtex>=2.1", | |
"sphinx-click", | |
"pydata-sphinx-theme>=0.15.3", | |
"nbsphinx!=0.8.8", # c.f. https://github.com/spatialaudio/nbsphinx/issues/620 | |
"ipywidgets", | |
"sphinx-issues", | |
"sphinx-copybutton>=0.3.2,!=0.5.1", | |
"jupyterlite-sphinx>=0.13.1", # c.f. https://github.com/scikit-hep/pyhf/pull/2458 | |
"jupyterlite-pyodide-kernel>=0.0.7", | |
"jupytext>=1.14.0", | |
"ipython!=8.7.0", # c.f. https://github.com/scikit-hep/pyhf/pull/2068 | |
] |
(Also, the non-docs CI will fail, but that's because I've been too swamped to fix things that I know are erroring given PyTorch.)
No hurry I'm in a train just catching up on stuff; and it's not urgent; has few risks to conflict and easy to redo if needs be.
That should already be there: --- a/pyproject.toml
+++ b/pyproject.toml
@@ -121,6 +121,7 @@ docs = [
"pydata-sphinx-theme>=0.15.3",
"nbsphinx!=0.8.8", # c.f. https://github.com/spatialaudio/nbsphinx/issues/620
"ipywidgets",
+ "intersphinx_registry",
"sphinx-issues",
"sphinx-copybutton>=0.3.2,!=0.5.1",
"jupyterlite-sphinx>=0.13.1", # c.f. https://github.com/scikit-hep/pyhf/pull/2458 Also : who does not sort their extras ! |
I think one of the difference is it will point toward uproot stable instead of latest (which is the dev version).
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: