Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backport): Use 'method' arg for jax.numpy.percentile #2524

Conversation

meeseeksmachine
Copy link

@meeseeksmachine meeseeksmachine commented Jun 20, 2024

Backport PR #2522: feat: Use 'method' arg for jax.numpy.percentile

* Backport PR https://github.com/scikit-hep/pyhf/pull/2522.
* Change the argument name in jax.numpy.percentile from 'interpolation' to 'method'.
  No change to the lower bounds on jax and jaxlib is required as 'method' already
  existed as an argument in jax v0.4.1. This just deprecates the use of 'interpolation'.

Co-authored-by: Matthew Feickert <[email protected]>

@lumberbot-app lumberbot-app bot added the feat/enhancement New feature or request label Jun 20, 2024
@matthewfeickert matthewfeickert self-assigned this Jun 20, 2024
@matthewfeickert matthewfeickert added the backport Backport PRs from main to release branch label Jun 20, 2024
@matthewfeickert matthewfeickert changed the title Backport PR #2522 on branch release/v0.7.x (feat: Use 'method' arg for jax.numpy.percentile) feat(backport): Use 'method' arg for jax.numpy.percentile Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release/v0.7.x@47d5930). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/v0.7.x    #2524   +/-   ##
=================================================
  Coverage                  ?   98.19%           
=================================================
  Files                     ?       69           
  Lines                     ?     4547           
  Branches                  ?      804           
=================================================
  Hits                      ?     4465           
  Misses                    ?       49           
  Partials                  ?       33           
Flag Coverage Δ
contrib 97.73% <100.00%> (?)
doctest 98.02% <100.00%> (?)
unittests-3.10 96.19% <100.00%> (?)
unittests-3.11 96.19% <100.00%> (?)
unittests-3.12 96.19% <100.00%> (?)
unittests-3.7 96.17% <100.00%> (?)
unittests-3.8 96.21% <100.00%> (?)
unittests-3.9 96.23% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewfeickert matthewfeickert merged commit d23f5c4 into scikit-hep:release/v0.7.x Jun 20, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Backport PRs from main to release branch feat/enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants