Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(backport): Use importlib.metadata to get version info #2502

Conversation

meeseeksmachine
Copy link

@meeseeksmachine meeseeksmachine commented May 30, 2024

Backport PR #2477: docs: Use importlib.metadata to get version info

* Backport PR https://github.com/scikit-hep/pyhf/pull/2477
* pkg_resources is deprecated as an API, so stop using it.
   - c.f. https://setuptools.pypa.io/en/latest/pkg_resources.html
* importlib.metadata.version is the recommended way to get package
  version information.
   - c.f. https://docs.python.org/3/library/importlib.metadata.html

@lumberbot-app lumberbot-app bot added docs Documentation related need-to-backport tmp label until can be backported to patch release branch labels May 30, 2024
@matthewfeickert matthewfeickert self-assigned this May 30, 2024
@matthewfeickert matthewfeickert added backport Backport PRs from main to release branch and removed need-to-backport tmp label until can be backported to patch release branch labels May 30, 2024
@matthewfeickert matthewfeickert changed the title Backport PR #2477 on branch release/v0.7.x (docs: Use importlib.metadata to get version info) docs(backport): Use importlib.metadata to get version info May 30, 2024
@matthewfeickert matthewfeickert merged commit de3c23c into scikit-hep:release/v0.7.x May 30, 2024
17 of 19 checks passed
Copy link

codecov bot commented Aug 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release/v0.7.x@1dec306). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             release/v0.7.x    #2502   +/-   ##
=================================================
  Coverage                  ?   98.19%           
=================================================
  Files                     ?       69           
  Lines                     ?     4547           
  Branches                  ?      804           
=================================================
  Hits                      ?     4465           
  Misses                    ?       49           
  Partials                  ?       33           
Flag Coverage Δ
contrib 97.73% <ø> (?)
doctest 98.02% <ø> (?)
unittests-3.10 96.19% <ø> (?)
unittests-3.11 96.19% <ø> (?)
unittests-3.12 96.19% <ø> (?)
unittests-3.7 96.17% <ø> (?)
unittests-3.8 96.21% <ø> (?)
unittests-3.9 96.23% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Backport PRs from main to release branch docs Documentation related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants