Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(backport): Use str object for jupyterlite-sphinx jupyterlite_dir config #2501

Merged
merged 1 commit into from
May 30, 2024
Merged

fix(backport): Use str object for jupyterlite-sphinx jupyterlite_dir config #2501

merged 1 commit into from
May 30, 2024

Conversation

meeseeksmachine
Copy link

@meeseeksmachine meeseeksmachine commented May 30, 2024 •
edited by matthewfeickert
Loading

Backport PR #2458: fix: Use str object for jupyterlite-sphinx jupyterlite_dir config

* Backport PR https://github.com/scikit-hep/pyhf/pull/2458
* To avoid warning

WARNING: The config value `jupyterlite_dir` has type `PosixPath`, defaults to `str`.

 use a str for the jupyterlite-sphinx v0.13.0+ jupyterlite_dir config
 option.

@lumberbot-app lumberbot-app bot added docs Documentation related fix A bug fix need-to-backport tmp label until can be backported to patch release branch labels May 30, 2024
@matthewfeickert matthewfeickert self-assigned this May 30, 2024
@matthewfeickert matthewfeickert removed the need-to-backport tmp label until can be backported to patch release branch label May 30, 2024
@matthewfeickert matthewfeickert changed the title Backport PR #2458 on branch release/v0.7.x (fix: Use str object for jupyterlite-sphinx jupyterlite_dir config) fix(backport): Use str object for jupyterlite-sphinx jupyterlite_dir config May 30, 2024
@matthewfeickert matthewfeickert merged commit 1dec306 into scikit-hep:release/v0.7.x May 30, 2024
12 of 20 checks passed
@matthewfeickert matthewfeickert added the backport Backport PRs from main to release branch label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matthewfeickert matthewfeickert

Labels
backport Backport PRs from main to release branch docs Documentation related fix A bug fix
Projects
pyhf v0.7.7
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meeseeksmachine @matthewfeickert