Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use 'macos-13' runs-on to continue using x86 based macOS runners #2468

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

henryiii
Copy link
Member

@henryiii henryiii commented Apr 24, 2024

Committed via https://github.com/asottile/all-repos

* The 'macos-latest' `runs-on` option has been changed to
  be the Apple silicon based 'macos-14' runners. To continue
  to use the x86 based macOS runners use 'macos-13' instead.

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.21%. Comparing base (64ab264) to head (c004bf8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2468   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files          69       69           
  Lines        4543     4543           
  Branches      804      804           
=======================================
  Hits         4462     4462           
  Misses         48       48           
  Partials       33       33           
Flag Coverage Δ
contrib 97.79% <ø> (ø)
doctest 98.08% <ø> (ø)
unittests-3.10 96.23% <ø> (ø)
unittests-3.11 96.23% <ø> (ø)
unittests-3.12 96.23% <ø> (ø)
unittests-3.8 96.25% <ø> (ø)
unittests-3.9 96.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewfeickert matthewfeickert added CI CI systems, GitHub Actions need-to-backport tmp label until can be backported to patch release branch labels Apr 24, 2024
@matthewfeickert matthewfeickert changed the title ci: macos-latest is changing to macos-14 ARM runners ci: Use 'macos-13' runs-on key to continue using x86 based macOS runners Apr 24, 2024
@matthewfeickert matthewfeickert changed the title ci: Use 'macos-13' runs-on key to continue using x86 based macOS runners ci: Use 'macos-13' runs-on to continue using x86 based macOS runners Apr 24, 2024
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/dependencies-head.yml Show resolved Hide resolved
.github/workflows/release_tests.yml Show resolved Hide resolved
@matthewfeickert
Copy link
Member

Thanks @henryiii!

@matthewfeickert matthewfeickert merged commit 3161192 into main Apr 24, 2024
22 checks passed
@matthewfeickert matthewfeickert deleted the all-repos_autofix_all-repos-sed branch April 24, 2024 03:15
@matthewfeickert
Copy link
Member

@henryiii
Copy link
Member Author

FYI, GitHub just shipped 3.8 & 3.9 for AS on GHA.

matthewfeickert added a commit that referenced this pull request Apr 26, 2024
* Use the 'macos-latest' runs-on option which now defaults to 'macos-14' which are
  Apple silicon runners.
   - c.f. https://github.com/actions/runner-images/blob/e63a194563cb0bb3bc1493144fe0ef6804249b43/images/macos/macos-14-arm64-Readme.md
* Keep a 'macos-13' runners to continue to test Intel based macOS for the
  latest Python version.
   - c.f. https://github.com/actions/runner-images/blob/e63a194563cb0bb3bc1493144fe0ef6804249b43/images/macos/macos-13-Readme.md
* Updates PR #2468
@matthewfeickert matthewfeickert removed the need-to-backport tmp label until can be backported to patch release branch label May 30, 2024
matthewfeickert added a commit that referenced this pull request May 30, 2024
* Backport:
   - PR #2443
   - PR #2446
   - PR #2451
   - PR #2458
   - PR #2460
   - PR #2465
   - PR #2468
   - PR #2471
   - PR #2472
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI systems, GitHub Actions
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants