fix: Test xml.etree.ElementTree.Element truth value by 'is not None' #2459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In Python 3.14 testing the truth value of an xml.etree.ElementTree.Element is deprecated and will raise an exception. As of Python 3.12 this behavior will raise a DeprecationWarning: ``` DeprecationWarning: Testing an element's truth value will raise an exception in future versions. Use specific 'len(elem)' or 'elem is not None' test instead. ``` To avoid this, determine the truth element by using the 'elem is not None' method.
matthewfeickert
added
fix
|
This won't get properly fully tested until Python 3.12 is added to the CI matrix. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2459 +/- ##
==========================================
- Coverage 98.23% 98.21% -0.03%
==========================================
Files 69 69
Lines 4541 4541
Branches 804 804
==========================================
- Hits 4461 4460 -1
- Misses 46 48 +2
+ Partials 34 33 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I'm going to approve and merge this myself. As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team. |
matthewfeickert
removed
the
need-to-backport
|
@meeseeksdev backport to release/v0.7.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pyhf
that referenced
this pull request
May 30, 2024
…truth value by 'is not None'
matthewfeickert
added a commit
that referenced
this pull request
May 30, 2024
…not None' (#2499) * Backport PR #2459 * In Python 3.14 testing the truth value of an xml.etree.ElementTree.Element is deprecated and will raise an exception. As of Python 3.12 this behavior will raise a DeprecationWarning: ``` DeprecationWarning: Testing an element's truth value will raise an exception in future versions. Use specific 'len(elem)' or 'elem is not None' test instead. ``` To avoid this, determine the truth element by using the 'elem is not None' method. - c.f. https://docs.python.org/3.12/library/xml.etree.elementtree.html#element-objects Co-authored-by: Matthew Feickert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #2453
In Python 3.14 testing the truth value of an
xml.etree.ElementTree.Elementis deprecated and will raise an exception. As of Python 3.12 this behavior will raise aDeprecationWarning:To avoid this, determine the truth element by using the
elem is not Nonemethod.Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: