Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add Apple silicon macOS to CI #2447

Merged
merged 4 commits into from
Mar 12, 2024
Merged

ci: Add Apple silicon macOS to CI #2447

merged 4 commits into from
Mar 12, 2024

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Mar 8, 2024

Description

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Add Apple M1 runner to tests using 'macos-14' for the 'runs-on' key.
   - c.f. https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/
* Lower the tolerance for tests/test_calculator.py to reach agreement
  between amd64 and arm64.
* Skip doctest evaluation for arm64.

@matthewfeickert matthewfeickert added tests pytest CI CI systems, GitHub Actions labels Mar 8, 2024
@matthewfeickert matthewfeickert self-assigned this Mar 8, 2024
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.28%. Comparing base (af5d952) to head (f6d64c5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2447   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files          69       69           
  Lines        4539     4539           
  Branches      803      803           
=======================================
  Hits         4461     4461           
  Misses         45       45           
  Partials       33       33           
Flag Coverage Δ
contrib 97.86% <ø> (ø)
doctest 98.14% <ø> (ø)
unittests-3.10 96.29% <ø> (ø)
unittests-3.11 96.29% <ø> (ø)
unittests-3.8 96.32% <ø> (ø)
unittests-3.9 96.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewfeickert
Copy link
Member Author

wow. The whole macos-14 job runs in under 5 minutes. That's fast!

@matthewfeickert matthewfeickert merged commit be2fde2 into main Mar 12, 2024
20 of 21 checks passed
@matthewfeickert matthewfeickert deleted the ci/add-m1-runners branch March 12, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI systems, GitHub Actions tests pytest
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants