Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(backport): Skip callbacks with dead weakrefs while iterating over callbacks #2321

Merged
merged 1 commit into from
Sep 6, 2023
Merged

fix(backport): Skip callbacks with dead weakrefs while iterating over callbacks #2321

merged 1 commit into from
Sep 6, 2023

Commits on Sep 6, 2023

  1. fix(backport): Skip callbacks with dead weakrefs while iterating over… 

    … callbacks

* Backport PR https://github.com/scikit-hep/pyhf/pull/ 2310
* Check refs while processing callbacks in case a callee is de-ref'd during
  the callback process.
* Additionally flush after processing callbacks in case any callback de-ref's
  a callee.
* Note that no additional tests are added for this case as the problem arises from
  and intermediate callback triggering a garbage-collect. It is unclear how to force
  this scenario deterministically in testing.
* Add Jonas Rembser to contributors list.

Co-authored-by: Jonas Rembser <[email protected]>
    @wernerd-cern @guitargeek @matthewfeickert
    2 people authored and matthewfeickert committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    e6c38e4 View commit details
    Browse the repository at this point in the history