Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands the usage and notion of normalization modifiers. Now normalization modifiers can also come from weight or tree variations. For example, a weight-based systematic can define a variation from which a normalization effect is calculated.
This PR also allows the symmetrization of normalization systematics.
Changes are mainly affecting src/cabinetry/workspace.py where the workspace is created. src/cabinetry/configuration.py has also being changed so additional needed histograms are now build for normalization modifiers.
As a side note, it would be good to add a safety check during the creation of the configuration file in order to not allow different properties of Up and Down variations. For example, we might not want to allow: