Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add new scorer: MaNoScorer #289

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ambroiseodt
Copy link
Contributor

@ambroiseodt ambroiseodt commented Jan 9, 2025

Implementation of MaNo as an unsupervised realistic scorer.

This should answer #288.

  • Update README.md
  • Update docs/source/all.rst
  • Update skada/metrics.py
  • Update skada/tests/test_scorer.py
  • Update skada/deep/tests/test_deep_scorer.py

@ambroiseodt
Copy link
Contributor Author

ambroiseodt commented Jan 9, 2025

At the time of writing, I haven't changed the skada/deep/tests/test_deep_scorer.py yet and there are already failing test when it comes to torch and to the deep methods. It seems that the error is super' object has no attribute '__sklearn_tags__, which seems to be related to an update of sklearn (see StackOverflow. Maybe you already have you ever seen this error @tgnassou?

I will investigate that while also adding the MaNoScorer test for the deep methods.

@antoinecollas
Copy link
Collaborator

antoinecollas commented Jan 9, 2025

Yes, deep learning tests are failling because skorch v1.0.0 is not compatible with sklearn 1.6.0. They fixed skorch and we are waiting for a new release (see skorch-dev/skorch#1085).

In the meantine, you can test your PR with skorch 1.0.0 and sklearn 1.5.2.

@ambroiseodt
Copy link
Contributor Author

Thanks @antoinecollas, yes I am using skorch 1.0.0 and sklearn 1.5.2 in local, I will push the test_deep_scorers once it works locally for me

@ambroiseodt
Copy link
Contributor Author

Thanks @antoinecollas, yes I am using skorch 1.0.0 and sklearn 1.5.2 in local, I will push the test_deep_scorers once it works locally for me

@antoinecollas It seems that the skorch issue has been resolved :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants