Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Separate Lint and Tests + codecov configuration #135

Merged
merged 6 commits into from
Mar 5, 2024
Merged

Conversation

rflamary
Copy link
Collaborator

@rflamary rflamary commented Mar 5, 2024

No description provided.

@agramfort
Copy link
Contributor

what if you run

pre-commit run -a

locally?

@rflamary
Copy link
Collaborator Author

rflamary commented Mar 5, 2024

all passed. what is happening with my pre-commit (and the one on teh action...)

@agramfort
Copy link
Contributor

agramfort commented Mar 5, 2024 via email

@rflamary
Copy link
Collaborator Author

rflamary commented Mar 5, 2024

yes i installed it with your yml file (and i see passed when i commit but it does not correct the file). Local stuff is my problem but the Lint action should fail here anyway no?

@kachayev
Copy link
Collaborator

kachayev commented Mar 5, 2024

@rflamary Your code has changes in the __init__.py file, which is excluded in ruff.toml (the very first exclude)

@kachayev
Copy link
Collaborator

kachayev commented Mar 5, 2024

I also opened an issue #136 so we don't forget to make ruff work for base modules.

@kachayev
Copy link
Collaborator

kachayev commented Mar 5, 2024

I moved the linting error to a non-excluded file, now it works as expected (linting job fails).

@rflamary
Copy link
Collaborator Author

rflamary commented Mar 5, 2024

thanks so much @kachayev I did not understand what was happening. I will cleanup this and merge the PR (and make the Lint test necessary for merge)

@rflamary rflamary changed the title [WIP] Separate Lint and Tests [MRG] Separate Lint and Tests Mar 5, 2024
@rflamary rflamary changed the title [MRG] Separate Lint and Tests [MRG] Separate Lint and Tests + codecov configuration Mar 5, 2024
@rflamary rflamary merged commit 35a3897 into main Mar 5, 2024
7 checks passed
@rflamary rflamary deleted the lint branch November 27, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants