-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Separate Lint and Tests + codecov configuration #135
Conversation
what if you run pre-commit run -a locally? |
all passed. what is happening with my pre-commit (and the one on teh action...) |
do you have precommit that runs locally when you git commit?
… Message ID: ***@***.***>
|
yes i installed it with your yml file (and i see passed when i commit but it does not correct the file). Local stuff is my problem but the Lint action should fail here anyway no? |
@rflamary Your code has changes in the |
I also opened an issue #136 so we don't forget to make |
I moved the linting error to a non-excluded file, now it works as expected (linting job fails). |
thanks so much @kachayev I did not understand what was happening. I will cleanup this and merge the PR (and make the Lint test necessary for merge) |
No description provided.