Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and refactor the toHtmlString method in the Tag class #1653

Merged
merged 4 commits into from
Aug 11, 2024

Conversation

sualeh
Copy link
Collaborator

@sualeh sualeh commented Aug 11, 2024

Refactor the toHtmlString method in the Tag class to improve readability and maintainability.

  • Extract the attribute appending logic into a separate appendAttributes method.
  • Extract the background color appending logic into a separate appendBgColor method.
  • Extract the style class appending logic into a separate appendStyleClass method.
  • Extract the emphasized text appending logic into a separate appendEmphasizedText method.
  • Extract the inner tags appending logic into a separate appendInnerTags method.
  • Extract the closing tag appending logic into a separate appendClosingTag method.

For more details, open the Copilot Workspace session.

Refactor the `toHtmlString` method in the `Tag` class to improve readability and maintainability.

* Extract the attribute appending logic into a separate `appendAttributes` method.
* Extract the background color appending logic into a separate `appendBgColor` method.
* Extract the style class appending logic into a separate `appendStyleClass` method.
* Extract the emphasized text appending logic into a separate `appendEmphasizedText` method.
* Extract the inner tags appending logic into a separate `appendInnerTags` method.
* Extract the closing tag appending logic into a separate `appendClosingTag` method.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/schemacrawler/SchemaCrawler?shareId=XXXX-XXXX-XXXX-XXXX).
@sualeh sualeh merged commit 3635aa6 into main Aug 11, 2024
43 of 44 checks passed
@sualeh sualeh deleted the sualeh/refactor-tohtmlstring branch August 11, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant