Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch an exception in get-all #127

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Catch an exception in get-all #127

merged 2 commits into from
Jun 25, 2024

Conversation

yito88
Copy link
Member

@yito88 yito88 commented Jun 23, 2024 •
edited
Loading

Description

In transfer and transfer-append tests in ScalarDB tests, get-all which reads all the final state misbehaved.
The dummy writes were committed even though the read failed due to conflicts. Then the get-all transaction was retried.
It caused the unexpected version increasing. That's why the check phase failed.

Related issues and/or PRs

Daily Jepsen test failed

Changes made

  • Catch the exceptions when transaction reads

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

Provide any additional information or notes that may be relevant to the reviewers or stakeholders.

yito88
yito88 commented Jun 23, 2024
View reviewed changes
scalardb/test/scalardb/core_test.clj
@@ -25,7 +25,9 @@
(condp = column
"tx_id" (Optional/of (TextValue. column id))
"tx_created_at" (Optional/of (BigIntValue. column (long 1566376246)))
"tx_state" (Optional/of (IntValue. column (Integer/parseInt id)))))))
"tx_state" (Optional/of (IntValue. column (Integer/parseInt id)))
;; for the coordinator table
Copy link
Member Author

@yito88 yito88 Jun 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unrelated to the bug fix.
For The group commit feature in the latest ScalarDB.

inv-jishnu
inv-jishnu approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@inv-jishnu inv-jishnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you.

brfrn169
brfrn169 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

feeblefakie
feeblefakie approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@feeblefakie feeblefakie merged commit 92d2434 into master Jun 25, 2024
3 checks passed
@feeblefakie feeblefakie deleted the fix/get-all-exceptions branch June 25, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inv-jishnu inv-jishnu inv-jishnu approved these changes

@feeblefakie feeblefakie feeblefakie approved these changes

@brfrn169 brfrn169 brfrn169 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yito88 @brfrn169 @feeblefakie @inv-jishnu