Request transfer transactions in parallel #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komamitsu
reviewed
Apr 15, 2024
scalardb/project.clj
Outdated
| @@ -9,7 +9,8 @@ | |||
| [org.slf4j/slf4j-jdk14 "2.0.6"] | |||
| [cassandra "0.1.0-SNAPSHOT"] | |||
| [cheshire "5.12.0"] | |||
| [com.scalar-labs/scalardb-schema-loader "4.0.0-SNAPSHOT"]] | |||
| [com.scalar-labs/scalardb-schema-loader "4.0.0-SNAPSHOT" | |||
| :exclusions [org.slf4j/*]]] | |||
There was a problem hiding this comment.
Thanks for taking care of the issue!
There was a problem hiding this comment.
It was fixed by scalar-labs/scalardb#1665.
Reverted.
| [test op transfer-fn] | ||
| (let [results (pmap #(transfer-fn test %) (:value op))] | ||
| (if (some #{:commit} results) | ||
| ;; return :ok when at least 1 transaction is committed |
There was a problem hiding this comment.
:ok needs to be returned for this filtering even if only one transaction is committed?
There was a problem hiding this comment.
Right, it's just for the checker, Jepsen requires the type though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Each worker's ScalarDB transaction service requested transactions one by one though there are multiple workers.
This PR changes the transaction request to execute multiple transactions at once.
We can test concurrent transactions in more practical cases, especially for the group commit.
Related issues and/or PRs
Changes made
transfermax-num-txsto request transactions at onceChecklist
Additional notes (optional)