Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround Cassandra table setup issue #122

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

yito88
Copy link
Member

@yito88 yito88 commented Feb 10, 2024

Description

Cassandra's table setup failed repeatedly even though the waits were inserted.
This workaround tries Cassandra table setup without the schema loader.

Related issues and/or PRs

If this PR addresses or references any issues and/or other PRs, list them here.

Changes made

  • Add a function to open a Cassandra session
  • Restore the Cassandra table setup function
  • Convert the schemata to the Cassandra(Alia) format

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

Provide any additional information or notes that may be relevant to the reviewers or stakeholders.

@yito88 yito88 changed the title Workarounf Cassandra table setup issue Workaround Cassandra table setup issue Feb 10, 2024
Copy link
Contributor

@inv-jishnu inv-jishnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I have tested this in my local environment and everything was working as expected and I didn't face any issues.
Thank you.

Copy link
Contributor

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@yito88 BTW, have we identified the root cause of the issue that occurs only when using Schema Loader?

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!
Found one typo, so it would be great if you could merge it after it's fixed.

@@ -23,28 +25,84 @@
[r]
(Thread/sleep (reduce * 1000 (repeat r 2))))

(defn- get-cassandra-schema
"Only the current test schemata are covered
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Only the current test schemata are covered
"Only the current test schemas are covered

@feeblefakie feeblefakie merged commit be76b87 into master Feb 13, 2024
3 checks passed
@feeblefakie feeblefakie deleted the fix/wa-table-setup-failure branch February 13, 2024 04:51
feeblefakie added a commit that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants