Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db/Retry after deletion #118

Merged
merged 1 commit into from
Dec 12, 2023
Merged

db/Retry after deletion #118

merged 1 commit into from
Dec 12, 2023

Conversation

yito88
Copy link
Member

@yito88 yito88 commented Dec 8, 2023

Description

In ScalarDB test, retry after deleting the existing tables for the schema loader failure

Related issues and/or PRs

If this PR addresses or references any issues and/or other PRs, list them here.

Changes made

Add table deletion before the table creation retry

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

Provide any additional information or notes that may be relevant to the reviewers or stakeholders.

Copy link
Contributor

@feeblefakie feeblefakie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Copy link
Contributor

@inv-jishnu inv-jishnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the PR change in my local environment. I encountered the issue only once on testing that was during the first time only, the test was successful each time when I executed after that. I have added the details in this slack comment .
Overall LGTM!
Thank you.

@yito88 yito88 merged commit 2f774a4 into master Dec 12, 2023
3 checks passed
@yito88 yito88 deleted the fix/db-table-creation branch December 12, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants