Ignore missing files when compressing target directories

[majk-p]

This PR resolves #60

[majk-p]

@djspiewak please have a look

[djspiewak]

This is great! Thank you!

[djspiewak]

@majk-p Looks like some of the workflows need to be updated with the new flag!

[majk-p]

Thanks @djspiewak! just regenerated the workflows, should work now 🤞

[djspiewak]

I think it's actually the tests that are the problem. Specifically:

• non-existent-target
• sbt-native-thin-client
• check-and-regenerate

The easiest thing to do is probably go in and manually edit the ci.yml files in each to have the new flag on their tar invocations. You can check to make sure it's working correctly by running sbt scripted

[majk-p]

Sorry, I should've tested it locally. The ci.yml files are now adjusted, sbt scripted passed with no issues. It should be ready now.

[majk-p]

Looks like macos-latest failed due to tar: Option --ignore-failed-read is not supported. Doesn't macos go with regular gnu tar? is it just the workflow or does it break this way on desktop?

[djspiewak]

Doesn't macos go with regular gnu tar? is it just the workflow or does it break this way on desktop?

Seems to be that way on desktop as well. One way we can work around this is to just install our own tar.

[kubukoz]

I'm on macos and my tar is bsdtar, it does complain about the flag. Gnutar recognizes it.

edit: somehow I completely missed Daniel's comment saying basically the same thing 😂

[armanbilge]

Just saw this—I actually ran into this problem with feral and my solution was to mkdir -p all the targets instead, before the compressing step.

ThisBuild / githubWorkflowGeneratedUploadSteps ~= { steps =>
  val mkdirStep = steps.headOption match {
    case Some(WorkflowStep.Run(command :: _, _, _, _, _, _)) =>
      WorkflowStep.Run(
        commands = List(command.replace("tar cf targets.tar", "mkdir -p")),
        name = Some("Make target directories")
      )
    case _ => sys.error("Can't generate make target dirs workflow step")
  }
  mkdirStep +: steps
}

https://github.com/typelevel/feral/blob/579409b9e228854ba6ff3d8033cd5baa71793f4a/build.sbt#L45

Update: this fix is now automatically applied in sbt-typelevel.

[mdedetrich]

@armanbilge Should we aim to get this merged or is there some additional work that needs to be done that I am missing?

[armanbilge]

@mdedetrich unfortunately the fix in this PR doesn't work. You should port my fix from sbt-typelevel that I mentioned above.

[mdedetrich]

@armanbilge Thanks for the reply, I will close this PR then and we can reimplement the proper fix separately.