RFC: Add range check for variables #30
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add range check for variables using the ".flags" variable. Different types of ranges can be specified for strings, decimals and hex-values. - For string one can specify a regular expression for valid string. - For decimals one can specify an integer range - For hex values one can specify a bitmask The range is added by the '@' character after the access flags. Example: Environment: .flags=foo:sw@r"aaab+",bla:dw@100-200,blub:xw@0xffff foo=aaab bla=123 blub=0x1234 Commandline: $ fw_setenv foo aaac libuboot_set_env failed: -1 $ fw_setenv foo aaabbbb $ fw_printenv bla=123 blub=0x1234 foo=aaabbb Signed-off-by: Lukas Funke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is untested with U-Boot. I'm hope to get some feedback whether such feature is desirable or even makes sense before invensting more time in it (starting the counter-part in U-Boot).
As a use-case I see general validation for variables to prevent system misconfiguration.
Here the commit message/usage information:
Add range check for variables using the ".flags" variable. Different types of ranges can be specified for strings, decimals and hex-values.
The range is added by the '@' character after the access flags.
Example:
Environment:
.flags=foo:sw@r"aaab+",bla:dw@100-200,blub:xw@0xffff foo=aaab
bla=123
blub=0x1234
Commandline:
$ fw_setenv foo aaac
libuboot_set_env failed: -1
$ fw_setenv foo aaabbbb
$ fw_printenv
bla=123
blub=0x1234
foo=aaabbb