Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spanish: handle lack of cents part for whole-number currency values #611

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Spanish: handle lack of cents part for whole-number currency values #611

wants to merge 1 commit into from

Conversation

bryananderson
Copy link
Contributor

Fixes bug in Spanish currency handling when there is no cents part of the value

Changes proposed in this pull request:

  • Now we check if there is a cents part before we try to access it

Status

  • READY
  • HOLD
  • WIP (Work-In-Progress)

How to verify this change

Run tests (added integer test cases)

@bryananderson
Copy link
Contributor Author

I also want to note that base.py here calls parse_currency_parts() here which will assume that an integer value means cents rather than dollars/euros/etc--this is not intuitive to me at all, is it the desired behavior?

@coveralls
Copy link

Coverage Status

coverage: 98.083%. remained the same
when pulling c372e81 on bryananderson:spanish-no-cents
into 7df3db9 on savoirfairelinux:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryananderson @coveralls