Enable LTO by default on all platforms #247
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When LTO was first introduced in commit 55a7a94 (Enable LTO and -march=native, 2019-05-29), it was enabled by default on all platforms. Now that it is no longer broken in Nix on Darwin, this old default may be restored. The reported upstream issue (NixOS/nixpkgs#19098) has been resolved and the fix is already included in the `nixpkgs-unstable` branch. This also enables LTO again on platforms other than Darwin, where it was unintentionally disabled by default due to a programming error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old comment by @lrworth was spot on, but ended up drowning under further discussion, which led to LTO being enabled only on Darwin by default except in Nix. While my prime motivation was sorting it out for Nix, I ended up spotting the error for all platforms. 🤷