Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logperf7 #4126

Draft
wants to merge 70 commits into
base: master-qa
Choose a base branch
from
Draft

Logperf7 #4126

wants to merge 70 commits into from

Conversation

ClaudeROSSI
Copy link
Contributor

No description provided.

@ClaudeROSSI
Copy link
Contributor Author

@OliveGerste : Tobias, can you help?
We have a smartcharging test failing ... I think I didn't merge properly some changes, but I do not find which one.
Can you please have a look to the failing test?
Any hint would be helpful!

image

@OliveGerste
Copy link
Contributor

OliveGerste commented Apr 4, 2023

@OliveGerste : Tobias, can you help? We have a smartcharging test failing ... I think I didn't merge properly some changes, but I do not find which one. Can you please have a look to the failing test? Any hint would be helpful!

Hi @ClaudeROSSI,

Not an easy one to be honest. The fault is not on your side:

Short answer: Performance is too good now.
Long answer: The test assumes that the first transaction starts shortly before the second one. Normally this worked because the code execution took more time, so that we had 1 second difference between the transaction starts.
Due to the performance increase they start at the exact same time and the parameters are exactly the same which leads to another order how the the transactions are prioritised.
I provided a PR to fix this #4173
Let me know if this is sufficient.

@CLAassistant
Copy link

CLAassistant commented Apr 18, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ ClaudeROSSI
✅ OliveGerste
❌ lmargaron
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants