Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added mentions legales to technical settings / tenant back #3898

Open
wants to merge 5 commits into
base: master-qa
Choose a base branch
from

Conversation

cabch
Copy link
Contributor

@cabch cabch commented Oct 5, 2022

No description provided.

@cabch cabch changed the title added mentions legales to technical settings / tenant added mentions legales to technical settings / tenant back Oct 5, 2022
Copy link
Collaborator

@LucasBrazi06 LucasBrazi06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My 2 cents
Like the old time :-)

src/assets/schemas/common/common.json Outdated Show resolved Hide resolved
},
"legalStatus": {
"type": "string",
"sanitize": "mongo"
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe all this data goes to common.js as it can be reused in Company ;P
And why not making it a component like the address ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it could be reused by companies but we won't use it as seen with @ClaudeROSSI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and yes i should have made a new component as address or support 🤷🏻‍♀️

@@ -20,6 +20,34 @@
},
"components": {
"$ref": "tenant-components#/definitions/components"
},
"support": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also generic, can be reused in Company for instance ;-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants