Support ESP v2+ chip feature to divide BRP by 2 #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryfabricio
approved these changes
Jul 7, 2021
Fix according to suggestion of @henryfabricio
|
I think REG_IER is overwrite 0xFF by writeRegister |
fix: prevent REG_IER from being overwritten
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is a little rough, I think the best would be to calculate BRP and compare if it's too big then use the divider. But in the original codes the values of BTR0 and BTR1 is pre-calculated so I thought for first approach it fits. I could not test 20kbps so I can't be 100% confident that the values are correct.