-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add full bril-rs feature set to rs2bril #315
Conversation
Two quick questions:
|
|
Something like Lines 46 to 47 in 0eedeea
Program struct
|
@Pat-Lafon's useful comments aside, it looks like |
Thanks, @ajpal! @Pat-Lafon, if this looks good to you now, I'm down to merge. |
LGTM |
@sampsyo @Pat-Lafon Is this ready to merge then? Lmk if there are any other changes you'd like me to make! |
It should be good, just probably low on Adrian's busy queue. |
I was on vacation this week. 😃 Looks good though; thank you again! |
Similar to #312, this PR adds the full feature set to
rs2bril
so that we can depend on both.