Skip to content

Commit

Permalink
More bug fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
sampotts committed Apr 17, 2018
1 parent 7f079e0 commit 119b471
Show file tree
Hide file tree
Showing 23 changed files with 141 additions and 75 deletions.
7 changes: 5 additions & 2 deletions changelog.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
## v3.1.1
## v3.2.0

* Fullscreen fixes (thanks @friday)
* Menu fix for if speed not in config
Expand All @@ -7,7 +7,10 @@
* Safer check for active caption (thanks @Antonio-Laguna)
* Add custom property fallback (thanks @friday)
* Fixed bug for captions with no srclang and labels and improved logic (fixes #875)
* Fix for `playing` false positive
* Fix for `playing` false positive (fixes #898)
* Fix for IE issue with navigator.language (thanks @nicolasthy) (fixes #893)
* Fix for Vimeo controls missing on iOS (thanks @verde-io) (fixes #807)
* Fix for double vimeo caption rendering (fixes #877)

## v3.1.0

Expand Down
2 changes: 1 addition & 1 deletion demo/dist/demo.css

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions demo/dist/demo.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion demo/dist/demo.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion demo/dist/demo.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion demo/dist/demo.min.js.map

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions demo/src/js/demo.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ import Raven from 'raven-js';
});

// Setup the player
const player = new Plyr('video', {
const player = new Plyr('#player', {
debug: true,
title: 'View From A Blue Moon',
iconUrl: '../dist/plyr.svg',
Expand All @@ -57,7 +57,6 @@ import Raven from 'raven-js';
tooltips: {
controls: true,
},
settings: ['captions'],
/* controls: [
'play-large',
'restart',
Expand Down
2 changes: 1 addition & 1 deletion dist/plyr.css

Large diffs are not rendered by default.

52 changes: 36 additions & 16 deletions dist/plyr.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/plyr.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/plyr.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/plyr.min.js.map

Large diffs are not rendered by default.

52 changes: 36 additions & 16 deletions dist/plyr.polyfilled.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/plyr.polyfilled.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/plyr.polyfilled.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/plyr.polyfilled.min.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "plyr",
"version": "3.1.0",
"version": "3.2.0",
"description": "A simple, accessible and customizable HTML5, YouTube and Vimeo media player",
"homepage": "https://plyr.io",
"main": "./dist/plyr.js",
Expand Down
5 changes: 5 additions & 0 deletions src/js/controls.js
Original file line number Diff line number Diff line change
Expand Up @@ -581,6 +581,11 @@ const controls = {
list = pane && pane.querySelector('ul');
}

// If there's no list it means it's not been rendered...
if (!utils.is.element(list)) {
return;
}

// Update the label
const label = this.elements.settings.tabs[setting].querySelector(`.${this.config.classNames.menu.value}`);
label.innerHTML = controls.getLabel.call(this, setting, value);
Expand Down
Loading

0 comments on commit 119b471

Please sign in to comment.