FasterXML#248 - fix VerisonUti.versionFor() unintended to return null…

… instead of Version.unknownVersion() after commit 88c296c
sammyhk · Jan 26, 2016 · 18ad3bc · 18ad3bc
1 parent c1922ac
commit 18ad3bc
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/main/java/com/fasterxml/jackson/core/util/VersionUtil.java b/src/main/java/com/fasterxml/jackson/core/util/VersionUtil.java
@@ -71,7 +71,8 @@ protected VersionUtil()
      */
     public static Version versionFor(Class<?> cls)
     {
-        return packageVersionFor(cls);
+        Version version = packageVersionFor(cls);
+        return version == null ? Version.unknownVersion() : version;
     }
 
     /**

diff --git a/src/test/java/com/fasterxml/jackson/core/util/TestVersionUtil.java b/src/test/java/com/fasterxml/jackson/core/util/TestVersionUtil.java
@@ -28,4 +28,9 @@ public void testMavenVersionParsing() {
     public void testPackageVersionMatches() {
         assertEquals(PackageVersion.VERSION, VersionUtil.versionFor(UTF8JsonGenerator.class));
     }
+
+    public void testVersionForUnknownVersion() {
+        // expecting return version.unknownVersion() instead of null
+        assertEquals(Version.unknownVersion(), VersionUtil.versionFor(TestVersionUtil.class));
+    }
 }