Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement according the SAML specification #221

Closed
wants to merge 6 commits into from
Closed

Improvement according the SAML specification #221

wants to merge 6 commits into from

Commits on Jul 24, 2024

  1. Squash commits for saml_idp gem

    zogoo committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    3e58ea2 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2024

  1. [feat] Allow SP config force signature validation (#16) 

    * Allow SP config force signature validation

* Allow SP config force signature validation

Tested with Slack with Authn request signature option
---------

Co-authored-by: zogoo <[email protected]>
    @Zogoo
    Zogoo and zogoo authored Jul 27, 2024
    Configuration menu
    Copy the full SHA
    f151f07 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. [feat] Don’t ignore certificates without usage (#17) 

    I have tested with live SAML SP apps and it works fine

* Unspecified certifciate from SP metadata

---------

Co-authored-by: zogoo <[email protected]>
    @Zogoo
    Zogoo and zogoo authored Aug 14, 2024
    Configuration menu
    Copy the full SHA
    86a2105 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Try with proper way to update helper method (#19) 

    * Set minimum test coverage (saml-idp#207)

* Set minimum test coverage to a very high value for testing

* Update minimum coverage to actual current value

* Try with proper way to update helper method

* Correctly decode and mock with correct REXML class

* Drop the min coverage

---------

Co-authored-by: Mathieu Jobin <[email protected]>
Co-authored-by: zogoo <[email protected]>
    @Zogoo @mjobin-mdsol
    3 people authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    94196fe View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. [feat] Collect request validation errors (#18) 

    * wip add error collector

* Fix type and rewrite request with proper validation test cases

* Lead error render decision to gem user

* Validate the certificate's existence before verifying the signature.

---------

Co-authored-by: zogoo <[email protected]>
    @Zogoo
    Zogoo and zogoo authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    1071d67 View commit details
    Browse the repository at this point in the history

  2. Support lowercase percent-encoded sequences for URL encoding (#20) 

    Co-authored-by: zogoo <[email protected]>
    @Zogoo
    Zogoo and zogoo authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    ade27c3 View commit details
    Browse the repository at this point in the history