feat: Idp initiated-logging-out #214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taro1025
force-pushed
the
feat/idp-initiated-logging-out
branch
from
92927db
to
28e9362
Compare
Zogoo
reviewed
Sep 5, 2024
| builder = Builder::XmlMarkup.new | ||
| builder.LogoutRequest ID: response_id_string, |
There was a problem hiding this comment.
Can you please explain why it is necessary to remove this block?
There was a problem hiding this comment.
There's no particular reason for removing the block. I had applied a monkey patch to enable IdP-initiated single logout in my service, and I submitted that change with this PR.
However, I will add the SessionIndex since it seems to be necessary for SP-initiated single logout.
taro1025
force-pushed
the
feat/idp-initiated-logging-out
branch
from
f4c49c9
to
d7e4e4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#49
Added support for IdP-initiated Single Logout (SLO). Previously, this feature was not supported, and this PR implements the necessary changes to enable it.