-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternative to support multiple x509 Certificates via procs #211
base: master
Are you sure you want to change the base?
Conversation
…d passwords by providing procs in the idp configuration.
Not sure if that's a flaky test in CI, still trying to reproduce the issue locally to resolve. |
@pelted in here also, I think you have valid points, let us properly look at it and merge it after you fix the tests. |
You are right it seems like failing everywhere, let me look at it. |
any progress on this? |
@Zogoo I believe my latest commit should resolve the failing test if we could kick off the CI workflow and verify. |
What this PR does
Why
This is an alternative approach to supporting multiple x509 certificates, secret keys, and password. This uses procs in the SamlIdp configuration as an alternative to #186 and #209.
I have been using this approach for some time now using a service object as a finder for the appropriate cert and secret key.
Some examples for looking these up: